Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a compatibility issue with Capacitor 2.2.0 where Config does not contain any static methods #83

Closed
wants to merge 2 commits into from

Conversation

tchvu3
Copy link

@tchvu3 tchvu3 commented Jun 12, 2020

You can view the change in the change log:
https://github.com/ionic-team/capacitor/blob/master/CHANGELOG.md#220-2020-06-10

specifically:
"feat(android): move Config to be per-instance rather than a singleton (#3055) (b4815a5), closes #3055"

Compatible with Capacitor 2.2.0
Compatible with Capacitor 2.2.0
@spencerpauly
Copy link

This fixes it.

@jcesarmobile
Copy link

We have put the static Config back (ionic-team/capacitor#3126), but please, if you notice that we break something in a patch or minor release, report it in Capacitor repo.

Anyway, the change in this PR is still recommended as the static Config is now deprecated and will go away in a future 3.0.0 release.

@bleuscyther
Copy link

there are some changes introduced in version 2.2.0. I am guessing this is where the conflicts are coming from

@baumblatt
Copy link
Owner

Hi Avihu,

I think that this problem is already solved by another PR, but thank you anyway.

If I'm wrong, be encouraged to fix the conflicts and send the PR again.

Best regards,
Bernardo Baumblatt

@curiouscod3
Copy link

curiouscod3 commented Jul 19, 2020

I am using the latest Capacitor(2.3.x) wiith 2.3.1 .. Android Studio complains (No CapConfig)

node_modules/capacitor-firebase-auth/android/src/main/java/com/baumblatt/capacitor/firebase/auth/CapacitorFirebaseAuth.java:15: error: cannot find symbol
import com.getcapacitor.CapConfig;
^
symbol: class CapConfig
location: package com.getcapacitor

@gggiiia
Copy link

gggiiia commented Jul 20, 2020

I am using the latest Capacitor(2.3.x) wiith 2.3.1 .. Android Studio complains (No CapConfig)

node_modules/capacitor-firebase-auth/android/src/main/java/com/baumblatt/capacitor/firebase/auth/CapacitorFirebaseAuth.java:15: error: cannot find symbol
import com.getcapacitor.CapConfig;
^
symbol: class CapConfig
location: package com.getcapacitor

yep same issue :/

@seanaye
Copy link

seanaye commented Jul 27, 2020

@gggiiia @curiouscod3 I have the exact same issue. Have you found a fix?

EDIT:

Fixed with yarn add @capacitor/ios@latest @capacitor/android@latest

@baumblatt
Copy link
Owner

Hi @tchvu3 ,

We still need this PR? Can you please, revisit. Please resolve the conflicts or close this PR.

Best regards,
Bernardo Baumblatt

@tchvu3
Copy link
Author

tchvu3 commented Aug 5, 2020

hey there.
it seems that my PR is no longer needed, closing it

@tchvu3 tchvu3 closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants